plugin-knowledge-bases: update api endpoint to use source ids #BLT-983 #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
approved these changes
Aug 2, 2024
Comment on lines
-34
to
-41
| const responseSources = response.data.sources.map(source => { | ||
| return { | ||
| knowledgeBaseId: source.knowledge_base_id, | ||
| knowledgeSourceId: source.knowledge_source_id, | ||
| knowledgeChunkId: source.knowledge_chunk_id, | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
should the changes in this PR go in a 0.29.0 release? this is a breaking change. Maybe we can update just this plugin to 0.29.0 to maintain compatibility if needed
Iru89
changed the title
AinaVendrell
approved these changes
Aug 2, 2024
vanbasten17
force-pushed
the
BLT-983-update-knowledge-base-plugin
branch
from
67323ad to
dbd3be5
Compare
vanbasten17
changed the title
vanbasten17
force-pushed
the
BLT-983-update-knowledge-base-plugin
branch
from
dbd3be5 to
cd5d5b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update endpoint to
/knowledge_base/inference/This endpoint use source ids instead of source names
Context
Approach taken / Explain the design
To document / Usage example
Testing
The pull request...