botonic-cli: no read/write bot.config.json #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the attribute version
vanbasten17
approved these changes
Aug 27, 2024
| const packages = await this.readPackageJson() | ||
| static async get(appDirectory: string): Promise<BotConfigJSON> { | ||
| const spinner = ora({ | ||
| text: 'Getting bot config...', |
There was a problem hiding this comment.
i would remove this message, I think it is not needed for the user to know this is happening in the background
Iru89
merged commit 5961ceb
into
botonic-cli/axios-with-interceptors
4 of 5 checks passed
Iru89
added a commit
that referenced
this pull request
Oct 1, 2024
## Description When deploying a bot the cli will get bot config from the @Botonic packages installed, npm and node version . This config is send to backend in deploy endpoint. ## Context This config will be used to read bot information from the flow builder frontend. ## Approach taken / Explain the design PRs merged in this PR: - #2895 - #2894 - #2892 - #2885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description