botonic-react: ensure typing is visible by scrolling when typing is active #BLT-1243 #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
requested review from
Iru89,
AinaVendrell,
donihubtype and
MarcosCA
vanbasten17
force-pushed
the
BLT-1243-botonic-typing-indicator-not-always-shown-when-area-is-scrollable
branch
from
1c87705 to
9ae297a
Compare
Iru89
approved these changes
Nov 26, 2024
MarcosCA
reviewed
Nov 26, 2024
donihubtype
approved these changes
Nov 26, 2024
Iru89
force-pushed
the
BLT-1243-botonic-typing-indicator-not-always-shown-when-area-is-scrollable
branch
from
9ae297a to
be6be26
Compare
Iru89
force-pushed
the
BLT-1243-botonic-typing-indicator-not-always-shown-when-area-is-scrollable
branch
2 times, most recently
from
594961d to
dd607d6
Compare
…ing without margin to use ref.current.scrollIntoView
…sageBanner when input is focus
Iru89
force-pushed
the
BLT-1243-botonic-typing-indicator-not-always-shown-when-area-is-scrollable
branch
from
dd607d6 to
e0d00b6
Compare
MarcosCA
approved these changes
Dec 2, 2024
Iru89
approved these changes
Dec 2, 2024
Iru89
changed the title
Iru89
deleted the
BLT-1243-botonic-typing-indicator-not-always-shown-when-area-is-scrollable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review commit by commit
Refactor TypingIndicator to have a ref and a container. A container is needed to remove margin and add a padding because scrollIntoView with
endoption not scroll margin pixelsFixed typing indicator to be visible when there is a typing effect.
Add isInputFocus in webchatState to show UnreadMessagesBanner only when user is not focus in
Change the position to sticky so that it is always above the InputPanel (when the user types several lines of text the InputPanel can grow and the scroll down button should always be above it).
Context
When sending a user input the webchat is scrolled to bottom, but as we have more messages, when we send an input and webchat scrolls to bottom and we have a typing effect, it is not visible because is under the scrolled area.
In this PR, we are making sure that when typing is set to true, the webchat is scrolled again to bottom to make it visible.
TypingIndicator
Grabacion.de.pantalla.2024-11-27.a.las.19.12.33.mov
UnreadMessagesBanner
Grabacion.de.pantalla.2024-11-27.a.las.19.13.56.mov