Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve bump versions script #971

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

vanbasten17
Copy link
Contributor

@vanbasten17 vanbasten17 commented Oct 2, 2020

Set as Draft PR if it's not ready to be merged.

PR best practices Reference

Description

Automate even more package dependency updates for templates and botonic packages with deps to other botonic packages to speed up the process and minimize potential errors.

Usage

For example, for the next release we can do:
For preparing rc versions, we can run the bash script:
$ ./bump-version.sh 0.15.0-rc.0 rc
will leave the dependencies for templates, react and plugin-nlu in the following format:

./botonic-react/package.json
"@botonic/core": "0.15.0-rc.0"

For definitive versions, we can run the bash script:
$ ./bump-version.sh 0.15.0
will leave the dependencies for templates, react and plugin-nlu in the following format:

./botonic-react/package.json
"@botonic/core": "~0.15.0"

Context

Right now we were calling npm version $VERSION which updated both package.json and package-lock.json for every dependency, but we still need to manually replace the versions for all templates and botonic packages which have another botonic package as a dependency (botonic-plugin-nlu and botonic-react).

@dpinol maybe you have suggestions to improve this even more

@vanbasten17 vanbasten17 merged commit 18fb810 into master Oct 5, 2020
@vanbasten17 vanbasten17 deleted the chore/improve-bump-versions-script branch October 5, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants