Contentful/validation improvements #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asastre
approved these changes
Oct 13, 2020
Comment on lines
+90
to
+94
| - id: inbenta | ||
| name: inbenta | ||
| entry: scripts/qa/lint-package.sh packages/botonic-plugin-inbenta | ||
| language: system | ||
| files: ^packages/botonic-plugin-inbenta/ |
| import { testContentful } from '../contentful.helper' | ||
| import { ENGLISH } from '../../../src/nlp' | ||
|
|
||
| test('TEST: contentful button', async () => { |
There was a problem hiding this comment.
What does it test here exactly?
There was a problem hiding this comment.
@asastre
well, seen! I added asserts
it was never used by any bot
allows customizing the sink of the error messages. Improvement in prints of recursive exception stacks
Validate text.text also if !searchable Before, when shortText was empty, the contentful driver set it with the value of the name field. Now this is managed by the Button model, so that validate can report it
it might be confusing because: * we already set shortText with name when missing * we have the resumeError flag
check button target is available and type of delivered content add test for contentful element delivery
dpinol
force-pushed
the
contentful/validation-improvements
branch
from
80fa4f8 to
692262a
Compare
Merged
guinii
approved these changes
Oct 19, 2020
| } | ||
| } else if (this.logStack && contentfulError.stack) { | ||
| err += contentfulError.stack.split('\n').slice(0, 5).join('\n') |
There was a problem hiding this comment.
Maybe a bit "hacky" Why are you slicing here?
There was a problem hiding this comment.
we don't want to spam the logs with too long callstack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit
logger injection in ErrorReportingCMS: Not we allow customizing the sink of the error messages.Improvements in prints of recursive exception stacks
Improvements in Content.validate of text & shortText fields
Check that contentful button targets are available
Added asserts to asserts in ContentsValidator unit test
To document
breaking change: We remove the Context.fixMissingData flag. It was confusing because:
* we already set shortText with the name field when it's missing
* we have the resumeErrors option for contentful