Add see more courses button to intro page #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age, adding 'see more courses' link to intro page after displaying 12 courses
rw2
reviewed
Dec 17, 2020
| $index++; | ||
| if ($index >= 12) | ||
| { | ||
| echo ' more courses</a>'; |
There was a problem hiding this comment.
Why is this being echo-ed instead of being rendered by PHP.
ishunko
reviewed
Dec 17, 2020
ishunko
reviewed
Dec 17, 2020
| <div class="col span4"></div> | ||
| <div class="col span4"> | ||
| <p> | ||
| <a class="hyper-button" href="/courses/browse">'; |
There was a problem hiding this comment.
We can try using class="btn" here and not introduce .hyper-button
damionjunk
reviewed
Dec 17, 2020
| @@ -86,6 +87,23 @@ | |||
| { | |||
| $count++; | |||
| } | |||
| $index++; | |||
| if ($index >= 12) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the status of the PR?
[X] Ready.
[ ] Work in Progress.
[ ] Hold.
Are there any database schema changes?
[ ] Yes.
[X] No.
Description:
Related tickets:
STEMEd#734 https://stemedhub.org/support/ticket/734
Testing instructions: