exit search loop when tool asset css file is found #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From our discussion - site_css.css to be stored in top-level css directory. |
nkissebe
force-pushed
the
dev-njk-toolassets
branch
from
09f4feb to
ef9451a
Compare
look for importfile/exportfile css and image files in toplevel template directory
nkissebe
force-pushed
the
dev-njk-toolassets
branch
from
ef9451a to
1d2c9c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like the previous PR the search for the css file to serve doesn't stop at the first match like it should. Also it searches in the wrong path in the template directory (should be within a css directory).
This task is only used when exportfile and importfile in a hub workspace is called. This triggers a pop up window which loads a file transfer dialog whose styling can be override by the css file delivered by this task. The task exists rather than direct access because it is awkward to pass in the hub template name for exportfile to use. For a long time we used the awkward method but it broke a while back and I came up with this method but never deployed it. It is time to deploy it now. At least for nanohub which already has this fix in its com_tools component override.