Handling of emails on comments when submitter was not logged in #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2021 21:24
Related to ticket 2939 on Qubes and ticket 400081 on nanoHub, this will detect the condition when a user submitted a ticket while not logged in and did not provide a username. When these tickets are commented on instead of reporting the submitter was emailed but actually not sending the email this change will cause the email address used when submitting the ticket to be sent an email. Subsequent work will need to validate replies to these emails are handled correctly.
… confusing conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ticket 2939 on Qubes and ticket 400081 on nanoHub, this will detect the condition when a user submitted a ticket while not logged in and did not provide a username. When these tickets are commented on instead of reporting the submitter was emailed but actually not sending the email this change will cause the email address used when submitting the ticket to be sent an email. Subsequent work will need to validate replies to these emails are handled correctly.