require email address for publication contact #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkissebe
reviewed
Jul 26, 2023
| * @param integer $aid | ||
| * @return void | ||
| */ | ||
| public function saveItem($manifest, $blockId, $pub, $actor = 0, $elementId = 0, $aid = 0) |
There was a problem hiding this comment.
When/Where does saveItem() get called, I don't see anything in this PR using it?
There was a problem hiding this comment.
Contact Jerry to get a reply on this if he doesn't get back on his own.
There was a problem hiding this comment.
Hi Nick, saveItem() is called when clicking the "save" button on author editing form. Below is the specific call stack.
- saveDraft() in /plugins/projects/publications/publication.php is called, where "saveitem" task is processed and "saveItem" of curation model is called as $pub->_curationModel->saveItem($this->_uid, $element).
- In saveItem function of curation model, blocks model and its saveItem() is called.
$blocksModel = new Blocks($this->_db);
$blocksModel->saveItem($this->_blockname, $this->_block, $this->_blockorder, $this->_pub, $actor, $elementId); - In saveItem function of blocks model, the saveItem function in the model in models/blocks/review.php is called by code snippet below.
$block = $this->loadBlock($name);
$block->saveItem($manifest, $blockId, $pub, $actor, $elementId);
nkissebe
approved these changes
Oct 6, 2023
nkissebe
added a commit
that referenced
this pull request
Oct 6, 2023
Co-authored-by: nkissebe <nkisseberth@ucsd.edu>
nkissebe
pushed a commit
that referenced
this pull request
Oct 6, 2023
nkissebe
pushed a commit
that referenced
this pull request
Oct 6, 2023
nkissebe
pushed a commit
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the publication contact have valid email address so that we can reach out to the right person when dealing with the datasets that have been published for over 10 years. Please refer to ticket: https://purr.purdue.edu/support/ticket/2456 where a specification document is attached, as well as a gif about how the function works. The changes have been tested in local development environment.