Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch of author in citation between Citation View and Software Download Citation Tab #1650

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

jessewoo
Copy link
Contributor

@jessewoo jessewoo commented Aug 3, 2023

Reference

Summary of the Issue

  • Client GeoDynamics found that different authors were showing in the citation tabs for a resource where the search results of citations of that same scientific journal article showed the right authors.

Summary of the Development

  • Looking at the SQL statement, with the inner joins of tables 'jos_citations_assoc' and 'jos_citations', the right key should have been given to 'jos_citations_authors' should have been CID - the citation id, and not the table id. With table id of 1445 given, it picked up the related author and used that. But using CID of 1393, it returns nothing for related authors, and will use the string of authors from the citation array object.
  • All was done in production environment on GeoDynamics because the need for real data.
  • Looked at logs, SQL tables and CMS code.

Testing Strategy

Manually tested working on production GeoDynamics

@nkissebe nkissebe merged commit 9e757f1 into dev Oct 5, 2023
@nkissebe nkissebe deleted the mismatchofAuthors branch April 18, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants