Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NCN-502] move youtube link to the online lecture column in course re… #1666

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

JackS9
Copy link
Contributor

@JackS9 JackS9 commented Aug 31, 2023

Adjustment to course lecture presentation for resources type courses

  • JIRA Card: https://sdx-sdsc.atlassian.net/browse/NCN-502
  • Support Ticket: https://nanohub.org/support/ticket/378550
  • Brief summary of the issue:
    This was a wishlist item from NanoHUB for course resource layout. If there is a child resource with a youtube child (logical type youtube), show youtube link in the online lecture column along with Hubpresenter child resources instead of in the supplemental materials column.
  • Brief summary of the fix/changed code: 1) Created $logical_alias from alias of child logical_type, similar to how $alias is used for child type, to use strings instead of numeric codes in if and switch statements (much more readable and less prone to changes in numeric codes). 2) Child type aliases of 'elink' and 'youtube' were set to logical_type alias of 'YouTube'. 3) The 'youtube' subtype was then added to the online lecture column instead of defaulting to the supplemental materials column.
  • Brief summary of your testing: Tested on personal VirtualBox VM with sample resource containing a YouTube link.
  • Needs to be hotfixed to any production hubs? No

@nkissebe nkissebe force-pushed the dev branch 3 times, most recently from e42b6ed to 8d38cdf Compare October 6, 2023 20:26
Copy link
Contributor

@nkissebe nkissebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. But I am not 100% certain this is the best/proper way to implement but seems good enough.

@dbenham dbenham merged commit 2e88beb into dev Nov 15, 2023
@nkissebe nkissebe deleted the ncn502 branch April 18, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants