[PURR][#2470] Hide the download link for 10-year dataset

[kuang5]

PURR ticket: https://purr.purdue.edu/support/ticket/2470

Processing 10-year datasets on PURR

We have talked about how to process the 10-year datasets on PURR. Pascal is going to setup PURR datasets Globus collection and share it with all PURR staff, so that we can transfer the dataset to PURR directory in Purdue Fortress storage system, where we are going to share the dataset by users' request.

On PURR, the download link on dataset page is going to be disabled and replaced with prompting language on how to access the dataset when they are scoped as 10-year datasets. The committed changes reflect this requirement.

There is a document attached in the PURR ticket, which specifies the summary of code change and how to test the feature. Please let me know when you have any questions.

[nkissebe]

This appears to only include the backend code, I don't see any views changed to reflect this. Also am concerned the default value for downloadable is false which implies to me this would make everything not downloadable when this is applied to a hub.

[kuang5]

Hi Nick, please look at the view change through links: https://gitlab.hubzero.org/purr/tmpl_doi/-/merge_requests/6 and https://gitlab.hubzero.org/purr/tmpl_doi/-/merge_requests/5. I also changed the downloadable to downloadDisabled, and recommitted it.

[nkissebe]

Jerry, could you add a copy of the front end view that you use in your override to the core view. Since we are adding this to the core admin then it should have some effect in the core view as well otherwise it is just confusing.

[dbenham]

@kuang5 - Jerry, could you address some of the other issues Nick brought up on this PR? Thanks

[kuang5]

Nick

Hi Dave, I have modified and committed the code changes according to Nick's comments in the past weeks. Please let me know when there are still any questions.

[dbenham]

@kuang5 - Jerry, am I missing something, I didn't see any changes resulting from Nick's comments?

[dbenham]

@kuang5

I reviewed this change with the group in our weekly dev meeting. I'd like to ask you go make the wording to the end usera bit more generic. So, instead of referring to 10 year old datasets, put text in there to the effect:

"This downloading this dataset has been disabled. Please submit a ticket to inquire about the current status of this dataset"

This way, other hubs can make use of this feature for whatever reason they want. I could imagine some hubs disabling download due to licensing reasons, perhaps legal reasons, or dataset size, etc, etc.

With this rewording, the entire group thought this would be s great addition to the core code. Thanks for submitting.

[dbenham]

@kuang5 - an old PR, but it looks like this might have fallen in between the cracks. If you can make the changes requested, we can reconsider this. It is a good feature, just needs some rewording to make it more generic for use in core hubzero.

[kuang5]

@dbenham
Hi Dave, I have committed the changes to language to "The downloading to this dataset has been disabled. Please submit a ticket to inquire about the current status of this dataset". Please let me know if there are anything else need to be updated.