Include latest commit hash in version info #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would sometimes be useful to get the hash of the latest commit Porymap was compiled with when getting bug information from users.
The displayed commit is only accurate once the Makefile is regenerated from
porymap.proandaboutporymap.cppis recompiled, but this is also true for the version info (except it'smainwindow.cppinstead) so I'm not super worried about it.Need to investigate what's happening in the GitHub actions for this(the commit hash for Linux and macOS was not in the repo, but that's because it was the hash of the pull request's test merge. This won't be a problem once it's actually merged)