Add actual preview to Export Map Stitch Image #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #499
Addresses confusion about what the "Stitch Image" feature does by displaying an actual preview of the image that will be created. The image can obviously be quite large, so the preview will now scale to fit the view. The original behavior for the preview (showing the image at the normal scale for the map editor) is preserved with a "Preview actual size" setting.
Also adds a brief description at the top of the window describing what the current image exporter will do.
Changing settings (which recreates the preview) is now likely to be significantly slower for most stitch images. I think this is a fine trade-off, having a real preview is valuable and I don't think toggling a bunch of settings is the main use case here.
(Final note, the diff in the form is mostly QtCreator relocating things. Aside from the label there were only some minor changes to give the preview more space)
UPDATE: Added an
Allsetting for events so if someone wants to toggle on all the event settings for a stitch map they don't need to wait for it to update 5 times. Also noticed an unrelated bug that I'll fix later (the map connections used for the image export are the connections for the map in the editor -- which can change -- not the map in the export window).