Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IISNode IICluster and Autoscaler classes #58

Merged
merged 12 commits into from
Jul 27, 2015

Conversation

chrisgilbert
Copy link
Contributor

I have been using the following to test.

from tyr.clusters.iis import IISCluster
IISCluster(group='chrisgtest', environment='stage', ami='ami-bea09bd6', subnet_ids=["subnet-961652e1", "subnet-9a41d9c3"], desired_capacity=2, min_size=1, max_size=3).autorun()

There are a few issues that need ironing out:

  • Problem spinning up servers once in ASG. Need to diagnose

@jamiegs
Copy link
Contributor

jamiegs commented Jul 13, 2015

I don't think you'll need to worry about Classiclinking. We've got all of our prod web server in VPC, and we're probably not going to need to classic link when migrating or stage servers

"cloudwatch:ListMetrics",
"cloudwatch:PutMetricAlarm",
"cloudwatch:PutMetricData",
"cloudwatch:SetAlarmState"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would need access to route53:ChangeResourceRecordSets as well

Autoscaler setup class
'''

log = logging.getLogger('Clusters.AutoScaler')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module should either be moved to the tyr.clusters package or the logger name should be changed to correctly reflect the package it belongs to - perhaps Autoscaling.Autoscaler (if the package were renamed autoscaling).

@chrisgilbert
Copy link
Contributor Author

OK, I have made changes as discussed.

chrisgilbert pushed a commit that referenced this pull request Jul 27, 2015
Add IISNode IICluster and Autoscaler classes
@chrisgilbert chrisgilbert merged commit d9b6aa2 into master Jul 27, 2015
@chrisgilbert chrisgilbert deleted the STRUCT-AddIISNodeType branch July 27, 2015 12:59
@chrisgilbert chrisgilbert restored the STRUCT-AddIISNodeType branch July 27, 2015 13:02
@chrisgilbert
Copy link
Contributor Author

Meh, my revert didn't reopen the pull request. Not sure what's happened there. I will create a new pull request for these changes

@chrisgilbert chrisgilbert deleted the STRUCT-AddIISNodeType branch July 30, 2015 08:53
@chrisgilbert chrisgilbert restored the STRUCT-AddIISNodeType branch July 30, 2015 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants