-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce TPU Pod launching to accelerate launch
#1049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
added
enhancement
New feature or request
TPU
Bug or feature on TPU platforms
labels
Feb 8, 2023
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this!
This was referenced Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed API:
accelerate launch
now allows for a configured pod setup through three new params/config items:use_cluster
, whether to use a TPU clustervm
, this mimicsxla_dist
'svm
argument and is a list of single compute VM names if you are not using an instance group. (generally not needed)env
, this is a list of environment variables to set on each of the compute VM instancesCurrently we only support non-Docker, as GCP doesn't support docker yet on the larger pods.
To launch a script on a TPU pod, the API will look like such:
Fully configured:
No configuration:
Note that if file permissions are given on your GCP cluster, there is a
--tpu_use_sudo
flag for this, and I recommend also doingsudo accelerate launch ...
plussudo pip install git+https://github.com/huggingface/accelerate
. On my specific configuration it was needed, but other users reported they didn't so it's optional.Closes #501 and closes #471