Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix args failure by adding in the defaults #1053

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Fix args failure by adding in the defaults #1053

merged 1 commit into from
Feb 9, 2023

Conversation

muellerzr
Copy link
Collaborator

The post-filtered GPU params to launch need to maintain the script and arg parameters. This PR adds them in.

Running on the nightly-ci to be sure before merging

@muellerzr muellerzr added the bug Something isn't working label Feb 9, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 9, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@muellerzr muellerzr merged commit cb993d7 into main Feb 9, 2023
@muellerzr muellerzr deleted the fix-args branch February 9, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger