[Big model loading] Correct GPU only loading #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
This was referenced Feb 27, 2023
sgugger
approved these changes
Feb 28, 2023
tests/test_modeling_utils.py
Outdated
Comment on lines
433
to
435
| for k, v in device_map.items(): | ||
| v = v if v != "disk" else "cpu" | ||
| self.assertEqual(loaded_state_dict[k].device, torch.device(v)) |
There was a problem hiding this comment.
Let's use proper names here instead of k, v (like param, device).
patrickvonplaten
commented
Mar 1, 2023
patrickvonplaten
commented
Mar 1, 2023
patrickvonplaten
commented
Mar 1, 2023
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
|
Merging as Sylvain has ✔️ -ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when loading safetensors directly on GPU via
device_map="auto"indiffusers.The test shows the failure case.