Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand warning and grab all GPUs available by default #1134

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Expand warning and grab all GPUs available by default #1134

merged 2 commits into from
Mar 1, 2023

Conversation

muellerzr
Copy link
Collaborator

Modifies the default for launch to grab all of the GPUs available if called without specifying anything. Will then also set multi_gpu to True.

@muellerzr muellerzr added the enhancement New feature or request label Mar 1, 2023
@muellerzr muellerzr requested a review from sgugger March 1, 2023 18:40
sgugger
sgugger approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 1, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr merged commit 586941d into main Mar 1, 2023
@muellerzr muellerzr deleted the expand-warn branch March 1, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger