[BigModeling
] Final fix for dispatch int8 and fp4 models
#1660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a silent bug regarding buffers that are not in the state dict of the model and when using quantized models. Currently the following snippet fails:
With the following error:
Because in #1652 we introduced a check to do nothing in case the model is quantized. This leads to buffers that are not in the state dict being on CPU.
As the
.to
operation is not supported for quantized models, the fix is to always force-dispatch the model if the model is quantized.cc @sgugger @SunMarc
Currently the corresponding test is implemented in huggingface/transformers#24543 as it relies on the main branch of transformers.