-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable pypi for merge workflows + fix trainer tests #2153
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just to be sure, did we ever encountered a situation were the tests were failing on pypi but not on the main branch of transformers ? If that's not the case, it makes sense to disable pypi.
@SunMarc yes, because a fix was put into the main in transformers and then propagated once the next release came out. This CI will still run on pypi for releases + nightly, but we don't need that level of feedback on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable, thanks for making the change. Just for my understanding, what is the issue with the trackers?
@BenjaminBossan unrelated test failures due to comet-ml not liking how certain things are setup, and the examples tests pull them all in automatically. Rather than dealing with faking the trackers/mocks/etc etc on the transformers side just uninstall them so as to not worry about it |
What does this PR do?
Disables the
pypi
release tests for merge and PR CI's. Unnecessary feedback and should reduce main CI time by ~10min and uninstalls trackers to fix the issues with the transformers testsBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@BenjaminBossan