Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nb tests #2230

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Fix nb tests #2230

merged 8 commits into from
Dec 11, 2023

Conversation

muellerzr
Copy link
Collaborator

Noticed the notebook_launcher tests weren't actually being ran due to a few issues. These fix them and moves it under AccelerateLauncher since it's spawned via just python

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

BenjaminBossan
BenjaminBossan approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, finally. LGTM, just some nits.

src/accelerate/launchers.py Show resolved Hide resolved
src/accelerate/utils/environment.py Show resolved Hide resolved
src/accelerate/test_utils/scripts/test_notebook.py Outdated Show resolved Hide resolved
BenjaminBossan
BenjaminBossan approved these changes Dec 7, 2023
View reviewed changes
src/accelerate/utils/environment.py Show resolved Hide resolved
src/accelerate/test_utils/scripts/test_notebook.py Outdated Show resolved Hide resolved
@muellerzr muellerzr merged commit eff30e2 into main Dec 11, 2023
25 checks passed
@muellerzr muellerzr deleted the fix-notebook-tests branch December 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @BenjaminBossan