Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add back dvclive to tests #2280

Merged
merged 3 commits into from
Jan 5, 2024
Merged

add back dvclive to tests #2280

merged 3 commits into from
Jan 5, 2024

Conversation

dberenbaum
Copy link
Contributor

What does this PR do?

Reverts/fixes #2279

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr PTAL. DVCLive 3.5.1 was released with a fix for this issue.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@dberenbaum
Copy link
Contributor Author

Also improved the step handling so it will be handled automatically if no step is explicitly passed.

muellerzr
muellerzr approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I'll ping here in case I notice any more failures on our nightlies :)

@muellerzr muellerzr merged commit 07df5d2 into huggingface:main Jan 5, 2024
23 checks passed
@dberenbaum
Copy link
Contributor Author

Thanks @muellerzr and happy new year!

statelesshz pushed a commit to statelesshz/accelerate that referenced this pull request Jan 22, 2024
add back dvclive to tests (huggingface#2280)
47c715c 
* add back dvclive

* dvclive tracker: handle and test step increments

* fix python<3.9 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dberenbaum @HuggingFaceDocBuilderDev @muellerzr