Fix infer_auto_device_map when tied weights share the same prefix name #2324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, thanks to @Giuseppe5 & @nickfraser notice.
On main currently, the detection of
tied_param_goups
andtied_params
is wrong as e.g. if we have a group["compute.weight", "compute.weight_submodule.parameter"]
and we are currently treating the parametercompute.weight
,tied_param_goups
will wrongfully be empty asall(name in k for k in tied_group)
is True.This result in an error in this example:
The error does not exist if we use the name
self.brrrweight_submodule
instead ofself.weight_submodule
.