Fix block_size picking in megatron_lm_gpt_pretraining example.
#2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only cap `block_size` to 1024 if `tokenizer.model_max_length` is actually greater than 1024.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ji-huazhong
pushed a commit
to ji-huazhong/accelerate
that referenced
this pull request
Jan 22, 2024
…ce#2342) Only cap `block_size` to 1024 if `tokenizer.model_max_length` is actually greater than 1024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If no
block_sizeis explicitly passed, and the tokenizer happens to have amodel_max_lengthof less than 1024, the current example will produce a badblock_size. With this change, we only capblock_sizeto 1024 iftokenizer.model_max_lengthis actually greater than 1024.Who can review?
Tagging @pacman100 / @sgugger as the authors of the surrounding code.