Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FSDP docs #2430

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Update FSDP docs #2430

merged 2 commits into from
Feb 9, 2024

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. States an important detail when using fsdp_cpu_ram_efficient_loading.
  2. Adds a section with a mapping between FSDP sharding strategies and DeepSpeed ZeRO Stages.

@pacman100 pacman100 mentioned this pull request Feb 9, 2024
Merged
1 task
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@pacman100 pacman100 marked this pull request as ready for review February 9, 2024 09:28
BenjaminBossan
BenjaminBossan approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the FSDP docs. I'm not knowledgeable enough to fully review the correctness, but from what I can tell, this LGTM. Left a few comments, but they're only nits.

docs/source/usage_guides/fsdp.md Outdated Show resolved Hide resolved
docs/source/usage_guides/fsdp.md Show resolved Hide resolved
muellerzr
muellerzr approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @pacman100!

@pacman100 pacman100 merged commit 86228e3 into huggingface:main Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacman100 @HuggingFaceDocBuilderDev @BenjaminBossan @muellerzr