Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tied_pointers_to_remove type #2439

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix tied_pointers_to_remove type #2439

merged 1 commit into from
Feb 13, 2024

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Feb 13, 2024

Keep this variable as a set, since some people may call post_forward multiple times.

Having it reset as None is breaking in the sense that post_forward may be called multiple times before, while it can not anymore on main.

Context: huggingface/optimum-amd#62

@fxmarty fxmarty requested a review from SunMarc February 13, 2024 13:45
@fxmarty
Copy link
Contributor Author

fxmarty commented Feb 13, 2024

cc @Giuseppe5

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@fxmarty fxmarty merged commit b38590a into main Feb 13, 2024
25 checks passed
@fxmarty fxmarty deleted the fix-none-error branch February 13, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants