Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning when dispatching model #2442

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

SunMarc
Copy link
Member

@SunMarc SunMarc commented Feb 13, 2024

What does this PR do ?

This PR fixes the wraper around .to() method when we dispatch the model. We were displaying this warning even when the user was not moving the model but casting the model to a specific dtype for example. cc @sayakpaul
Fixes one of the issues in this PR huggingface/diffusers#6857

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting fix, nice catch!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick resolve!

@SunMarc SunMarc merged commit 613ad70 into huggingface:main Feb 14, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants