Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit configuration #2451

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Add pre-commit configuration #2451

merged 1 commit into from
Feb 26, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Feb 15, 2024

What does this PR do?

This PR adds a pre-commit configuration, so developers may opt in to running ruff and ruff-format as a pre-commit hook.

Should reduce the need for "fix lint" commits and check_code_quality CI failures.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
    • Added to contributing readme.
  • Did you write any new necessary tests?
    • None required.

Who can review?

cc @muellerzr @BenjaminBossan

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as I've had for PEFT: I don't know yet if I'd personally use it, but since it's completely optional, there is no harm in adding this.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Same comment as Benjamin, but no harm in having it available :)

@muellerzr muellerzr merged commit 67e698c into huggingface:main Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants