Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for None #2452

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Check for None #2452

merged 1 commit into from
Feb 15, 2024

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

The CV models test showed a failure when args is defined but kwargs are none (why only them, unsure as gpt2 didn't face this, but I digress). This check makes sure that the padding is only checked for if the value is not None (otherwise we get an error about how we can't run it w/o a tensor-like item)

Fixes # (issue)

Failing test on main

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc

@muellerzr muellerzr requested a review from SunMarc February 15, 2024 15:26
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr muellerzr merged commit 97d2168 into main Feb 15, 2024
25 checks passed
@muellerzr muellerzr deleted the fix-pippy-tests branch February 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants