-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨🚨🚨Move to using tags rather than latest for docker images and consolidate image repos 🚨 🚨🚨 #2554
Conversation
New repo is located here: https://hub.docker.com/r/huggingface/accelerate/tags Looking at migrating the |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Huggingface/accelerate-gpu:latest -> huggingface/accelerate:gpu-latest
I think we don't have tag containing -latest
anymore.
Regarding how long to keep the images, I still think it's better to talk (or at least inform) the infra team. Not sure how large is an accelerate
image, but transformers
images are of around ~10G. (And I don't know if we will get problems when we have hundred of such images 😆 )
Thanks, yup adjusted as it's
Definitely the next step. Accelerate images on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for these changes make sense to me. As mentioned, the question about retention should probably be addressed.
Regarding the deprecation, there doesn't seem to be an official way: docker/hub-feedback#907. Not sure what can be done, really, except for mentioning it in the release notes.
@BenjaminBossan I more or less plan on doing the following:
Next steps from here are more fine-grained builds as needed internally and externally
|
What does this PR do?
Rather than having
huggingface/accelerate-gpu
huggingface/accelerate-cpu
+ a new repository for each new env that we will add (e.g. soon to be XLA and XLA_gpu), this PR centralizes all our docker images to just be inhuggingface/accelerate
and uses the right tags to make discovery and management easier.This PR also includes a README in
/docker
which mentions what images are available and how to run things.The Pros:
deepspeed
specific builds, XLA-specific builds, etc, which now can be pushed as a seperate tag instead of needing to make a ton of new repos)The Cons:
huggingface/accelerate-cpu
orhuggingface/accelerate-gpu
will not receive updated images.Not sure if there's a good way to alert users to the deprecation inside Docker, so we'll just need to do so thoroughly in comms.
The conversion:
huggingface/accelerate-gpu:latest
->huggingface/accelerate:gpu-nightly
huggingface/accelerate-cpu:latest
->huggingface/accelerate:cpu-nightly
New image tags
Nightlies are now built with versioning in mind for individuals to roll back to easily (or CI's). This helps us easily trakc down if a new dependency got released, when it happened, and what was new in the build.
huggingface/accelerate:{gpu,cpu}-nightly
huggingface/accelerate:{gpu,cpu}-nightly-{YYYY}-{MM}-{DD}
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ydshieh @BenjaminBossan