Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deepspeed env gen #2565

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Improve deepspeed env gen #2565

merged 2 commits into from
Mar 20, 2024

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

This PR improves the deepspeed env file generation by making sure any bad flags include a warning that they are being strict.

Avoid trailing newline and avoid writing some other characters that would break reading in this file.

DeepSpeed [code](https://github.com/microsoft/DeepSpeed/blob/688239e3f24f7ba11d3fe90bbe9670b7a61e5440/deepspeed/launcher/runner.py#L560) that reads from this file is naive and thus requires strict narrowing of legal key=value lines.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • [] Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@pacman100

muellerzr and others added 2 commits March 20, 2024 13:53
Co-authored-by: Rick Lamers <ricklamers@gmail.com>
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @muellerzr for the fixes and the test!

["ACCELERATE_DEBUG_MODE=1\n", "OTHER_ENV=2\n"]
```
"""
forbidden_chars = [";", "\n", "<", ">", " "]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose to not include = as in their official guide they recommend setting it in the .env variable using =

@muellerzr muellerzr merged commit c2f193a into main Mar 20, 2024
25 checks passed
@muellerzr muellerzr deleted the improve-deepspeed-env-gen branch March 20, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants