Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expound PartialState docstring #2589

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Expound PartialState docstring #2589

merged 10 commits into from
Mar 26, 2024

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

These merge conflicts are getting fun, but it's nice to see more people wanting better uses of PartialState!

In this one we explicitly discuss how to use InitProcessGroupKwargs with the PartialState, which is needed if you want to modify the init outside the Accelerator

Closes #2587

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expanding the docstring of PartialState.

@muellerzr muellerzr merged commit 5a232de into main Mar 26, 2024
25 checks passed
@muellerzr muellerzr deleted the partialstate-docstring branch March 26, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit initializations when using PartialState
3 participants