-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule free optimizer support #2631
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,225 @@ | ||
# Copyright 2024 The HuggingFace Inc. team. All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
import argparse | ||
import os | ||
|
||
import evaluate | ||
import torch | ||
from datasets import load_dataset | ||
from torch.utils.data import DataLoader | ||
from transformers import AutoModelForSequenceClassification, AutoTokenizer, set_seed | ||
|
||
from accelerate import Accelerator, DistributedType | ||
from accelerate.utils import is_schedulefree_available | ||
|
||
|
||
if is_schedulefree_available(): | ||
import schedulefree | ||
else: | ||
raise ImportError( | ||
"This example requires the `schedulefree` library. Please install it with `pip install schedulefree`" | ||
) | ||
|
||
|
||
######################################################################## | ||
# This is a fully working simple example to use Accelerate and Facebook's | ||
# scheduler-free optimizer: https://github.com/facebookresearch/schedule_free/ | ||
# | ||
# This example trains a Bert base model on GLUE MRPC | ||
# in any of the following settings (with the same script): | ||
# - single CPU or single GPU | ||
# - multi GPUS (using PyTorch distributed mode) | ||
# - (multi) TPUs | ||
# - fp16 (mixed-precision) or fp32 (normal precision) | ||
# | ||
# To run it in each of these various modes, follow the instructions | ||
# in the readme for examples: | ||
# https://github.com/huggingface/accelerate/tree/main/examples | ||
# | ||
######################################################################## | ||
|
||
|
||
MAX_GPU_BATCH_SIZE = 16 | ||
EVAL_BATCH_SIZE = 32 | ||
|
||
|
||
def get_dataloaders(accelerator: Accelerator, batch_size: int = 16): | ||
""" | ||
Creates a set of `DataLoader`s for the `glue` dataset, | ||
using "bert-base-cased" as the tokenizer. | ||
|
||
Args: | ||
accelerator (`Accelerator`): | ||
An `Accelerator` object | ||
batch_size (`int`, *optional*): | ||
The batch size for the train and validation DataLoaders. | ||
""" | ||
tokenizer = AutoTokenizer.from_pretrained("bert-base-cased") | ||
datasets = load_dataset("glue", "mrpc") | ||
|
||
def tokenize_function(examples): | ||
# max_length=None => use the model max length (it's actually the default) | ||
outputs = tokenizer(examples["sentence1"], examples["sentence2"], truncation=True, max_length=None) | ||
return outputs | ||
|
||
# Apply the method we just defined to all the examples in all the splits of the dataset | ||
# starting with the main process first: | ||
with accelerator.main_process_first(): | ||
tokenized_datasets = datasets.map( | ||
tokenize_function, | ||
batched=True, | ||
remove_columns=["idx", "sentence1", "sentence2"], | ||
) | ||
|
||
# We also rename the 'label' column to 'labels' which is the expected name for labels by the models of the | ||
# transformers library | ||
tokenized_datasets = tokenized_datasets.rename_column("label", "labels") | ||
|
||
def collate_fn(examples): | ||
# For Torchxla, it's best to pad everything to the same length or training will be very slow. | ||
max_length = 128 if accelerator.distributed_type == DistributedType.XLA else None | ||
# When using mixed precision we want round multiples of 8/16 | ||
if accelerator.mixed_precision == "fp8": | ||
pad_to_multiple_of = 16 | ||
elif accelerator.mixed_precision != "no": | ||
pad_to_multiple_of = 8 | ||
else: | ||
pad_to_multiple_of = None | ||
|
||
return tokenizer.pad( | ||
examples, | ||
padding="longest", | ||
max_length=max_length, | ||
pad_to_multiple_of=pad_to_multiple_of, | ||
return_tensors="pt", | ||
) | ||
|
||
# Instantiate dataloaders. | ||
train_dataloader = DataLoader( | ||
tokenized_datasets["train"], shuffle=True, collate_fn=collate_fn, batch_size=batch_size, drop_last=True | ||
) | ||
eval_dataloader = DataLoader( | ||
tokenized_datasets["validation"], | ||
shuffle=False, | ||
collate_fn=collate_fn, | ||
batch_size=EVAL_BATCH_SIZE, | ||
drop_last=(accelerator.mixed_precision == "fp8"), | ||
) | ||
|
||
return train_dataloader, eval_dataloader | ||
|
||
|
||
# For testing only | ||
|
||
|
||
if os.environ.get("TESTING_MOCKED_DATALOADERS", None) == "1": | ||
from accelerate.test_utils.training import mocked_dataloaders | ||
|
||
get_dataloaders = mocked_dataloaders # noqa: F811 | ||
|
||
|
||
def training_function(config, args): | ||
# Initialize accelerator | ||
accelerator = Accelerator(cpu=args.cpu, mixed_precision=args.mixed_precision) | ||
# Sample hyper-parameters for learning rate, batch size, seed and a few other HPs | ||
lr = config["lr"] | ||
num_epochs = int(config["num_epochs"]) | ||
seed = int(config["seed"]) | ||
batch_size = int(config["batch_size"]) | ||
|
||
metric = evaluate.load("glue", "mrpc") | ||
|
||
# If the batch size is too big we use gradient accumulation | ||
gradient_accumulation_steps = 1 | ||
if batch_size > MAX_GPU_BATCH_SIZE and accelerator.distributed_type != DistributedType.XLA: | ||
gradient_accumulation_steps = batch_size // MAX_GPU_BATCH_SIZE | ||
batch_size = MAX_GPU_BATCH_SIZE | ||
|
||
set_seed(seed) | ||
train_dataloader, eval_dataloader = get_dataloaders(accelerator, batch_size) | ||
# Instantiate the model (we build the model here so that the seed also control new weights initialization) | ||
model = AutoModelForSequenceClassification.from_pretrained("bert-base-cased", return_dict=True) | ||
|
||
# We could avoid this line since the accelerator is set with `device_placement=True` (default value). | ||
# Note that if you are placing tensors on devices manually, this line absolutely needs to be before the optimizer | ||
# creation otherwise training will not work on TPU (`accelerate` will kindly throw an error to make us aware of that). | ||
model = model.to(accelerator.device) | ||
# Instantiate optimizer with warmup steps | ||
optimizer = schedulefree.AdamWScheduleFree( | ||
model.parameters(), | ||
lr=lr, | ||
warmup_steps=100, | ||
) | ||
|
||
# Prepare everything | ||
# There is no specific order to remember, we just need to unpack the objects in the same order we gave them to the | ||
# prepare method. | ||
|
||
model, optimizer, train_dataloader, eval_dataloader = accelerator.prepare( | ||
model, optimizer, train_dataloader, eval_dataloader | ||
) | ||
|
||
# Now we train the model | ||
for epoch in range(num_epochs): | ||
model.train() | ||
optimizer.train() | ||
for step, batch in enumerate(train_dataloader): | ||
# We could avoid this line since we set the accelerator with `device_placement=True`. | ||
batch.to(accelerator.device) | ||
outputs = model(**batch) | ||
loss = outputs.loss | ||
loss = loss / gradient_accumulation_steps | ||
accelerator.backward(loss) | ||
if step % gradient_accumulation_steps == 0: | ||
optimizer.step() | ||
optimizer.zero_grad() | ||
|
||
model.eval() | ||
optimizer.eval() | ||
for step, batch in enumerate(eval_dataloader): | ||
# We could avoid this line since we set the accelerator with `device_placement=True`. | ||
batch.to(accelerator.device) | ||
with torch.no_grad(): | ||
outputs = model(**batch) | ||
predictions = outputs.logits.argmax(dim=-1) | ||
predictions, references = accelerator.gather_for_metrics((predictions, batch["labels"])) | ||
metric.add_batch( | ||
predictions=predictions, | ||
references=references, | ||
) | ||
|
||
eval_metric = metric.compute() | ||
# Use accelerator.print to print only on the main process. | ||
accelerator.print(f"epoch {epoch}:", eval_metric) | ||
|
||
|
||
def main(): | ||
parser = argparse.ArgumentParser(description="Simple example of training script.") | ||
parser.add_argument( | ||
"--mixed_precision", | ||
type=str, | ||
default=None, | ||
choices=["no", "fp16", "bf16", "fp8"], | ||
help="Whether to use mixed precision. Choose" | ||
"between fp16 and bf16 (bfloat16). Bf16 requires PyTorch >= 1.10." | ||
"and an Nvidia Ampere GPU.", | ||
) | ||
parser.add_argument("--cpu", action="store_true", help="If passed, will train on the CPU.") | ||
args = parser.parse_args() | ||
config = {"lr": 2e-5, "num_epochs": 3, "seed": 42, "batch_size": 16} | ||
training_function(config, args) | ||
|
||
|
||
if __name__ == "__main__": | ||
main() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
accelerate # used to be installed in Amazon SageMaker environment | ||
evaluate | ||
datasets==2.3.2 | ||
datasets==2.3.2 | ||
schedulefree |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a
@property
forself.optimizer.training
too? I don't think we also need a setter for this, astrain()
andeval()
should be enough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That gets to be optimizer-specific, so not a fan of it unless its downstreamed, as they currently don't have that: https://github.com/facebookresearch/schedule_free/blob/main/schedulefree/adamw_schedulefree.py#L86
(Otherwise I'd agree, yes that's a good idea)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, good point.