Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version checks for the import of DeepSpeed moe utils #2705

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add version checks for the import of DeepSpeed moe utils #2705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee7cada
fix import for moe utils
pacman100 Apr 24, 2024
2d2722f
Apply suggestions from code review
pacman100 Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/accelerate/utils/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,11 +975,13 @@ def _deepspeed_config_checks(self):
)

def set_moe_leaf_modules(self, model):
from deepspeed.utils import set_z3_leaf_modules

if self.transformer_moe_cls_names is None:
self.transformer_moe_cls_names = os.environ.get("ACCELERATE_DEEPSPEED_MOE_LAYER_CLS_NAMES", None)
if self.transformer_moe_cls_names is not None:
if compare_versions("deepspeed", "<", "0.14.0"):
raise ImportError("DeepSpeed version must be >= 0.14.0 to use MOE support. Please update DeepSpeed.")
from deepspeed.utils import set_z3_leaf_modules

class_names = self.transformer_moe_cls_names.split(",")
transformer_moe_cls = []
for layer_class in class_names:
Expand Down
4 changes: 2 additions & 2 deletions tests/deepspeed/test_deepspeed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,8 +813,8 @@ def test_ds_config(self, stage):
)
assert deepspeed_plugin.zero_stage == int(stage.replace("zero", ""))

def test_prepare_deepspeed_preapre_moe(self):
if compare_versions("transformers", "<", "4.40"):
def test_prepare_deepspeed_prepare_moe(self):
if compare_versions("transformers", "<", "4.40") and compare_versions("deepspeed", "<", "0.14"):
return
deepspeed_plugin = DeepSpeedPlugin(
zero3_init_flag=True,
Expand Down
Loading