Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment out a deepspeed docker image #2707

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Segment out a deepspeed docker image #2707

merged 3 commits into from
Apr 29, 2024

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented Apr 24, 2024

What does this PR do?

Deepspeed has required python v3.10, which is above our minimum. To keep with our 3.9 requirement, this PR adds a new docker image specific for deepspeed with the required tags

Should fix our tests on main

New tag added: huggingface/accelerate:gpu-deepspeed

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@pacman100

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr
Copy link
Collaborator Author

@muellerzr muellerzr marked this pull request as ready for review April 24, 2024 14:03
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Zach, I think DeepSpeed pinning is still required.

@muellerzr
Copy link
Collaborator Author

Thanks! Done!

Follow up will include using these docker images as part of the CI, and using uv to install (since it won't be CI based anymore and won't blow up)

@muellerzr muellerzr merged commit c7e5e41 into main Apr 29, 2024
25 checks passed
@muellerzr muellerzr deleted the deepspeed-image branch April 29, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants