Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert documentation to the new front #271

Merged
merged 8 commits into from
Mar 10, 2022
Merged

Convert documentation to the new front #271

merged 8 commits into from
Mar 10, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Mar 8, 2022

This PR ports Accelerate's doc to the new format.

@sgugger sgugger requested review from mishig25 and LysandreJik March 8, 2022 19:56
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 8, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@sgugger
Copy link
Collaborator Author

sgugger commented Mar 8, 2022 •
edited
Loading

Even if everything is pushed properly on doc-build-dev, there is nothing at https://moon-ci-docs.huggingface.co/docs/accelerate/pr_271. Guessing something needs to be activated on moon-landing @mishig25 ?

@sgugger sgugger mentioned this pull request Mar 8, 2022
Merged
@mishig25
Copy link

mishig25 commented Mar 8, 2022

Indeed, there needs to be a small update on moon-landing side. More info here
Screenshot 2022-03-09 at 00 02 02

@mishig25
Copy link

mishig25 commented Mar 8, 2022

I think ~ before Accelerator should not be there
Screenshot 2022-03-09 at 00 06 33

LysandreJik
LysandreJik approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super exciting! 🎉

@LysandreJik LysandreJik mentioned this pull request Mar 10, 2022
Closed
7 tasks
@sgugger sgugger merged commit fb5ed62 into main Mar 10, 2022
@sgugger sgugger deleted the new_doc_front branch March 10, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@mishig25 mishig25 Awaiting requested review from mishig25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sgugger @HuggingFaceDocBuilderDev @mishig25 @LysandreJik