Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on main #2739

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix tests on main #2739

merged 2 commits into from
May 3, 2024

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Fixes the following on our red CI:

  • We need to run gc.collect() and torch.cuda.empty_cache() on the memory test to make sure a full good reset state is present
  • Missing some @require on the pippy tests

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@muellerzr muellerzr requested a review from SunMarc May 3, 2024 14:09
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Just one question, why does pippy requires torchvision ?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr
Copy link
Collaborator Author

@SunMarc because there's a test in there for resnet 😉

@muellerzr muellerzr merged commit 060361f into main May 3, 2024
25 checks passed
@muellerzr muellerzr deleted the fix-tests-on-main branch May 3, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants