Support saving and loading of step while saving and loading state #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
muellerzr
approved these changes
Jun 10, 2024
|
Hi @muellerzr, thanks for the feedback! Just pushed the updates, let me know if this is good to go :) |
4 tasks
jmracek
reviewed
Aug 12, 2024
| @@ -240,6 +249,7 @@ def load_accelerator_state( | |||
| # Random states | |||
| try: | |||
| states = torch.load(input_dir.joinpath(f"{RNG_STATE_NAME}_{process_index}.pkl")) | |||
| override_attributes["step"] = states["step"] | |||
There was a problem hiding this comment.
This is a breaking change for people upgrading accelerate. If previously saved pickled states objects don't contain a "step" key, then random states fail to initialize correctly when you resume a training that was checkpointed from a prior version of accelerate.
There was a problem hiding this comment.
Correct, we've fixed this in a patch release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support to checkpoint the
step(internal step tracker) value while callingAccelerator.save_stateand also makes appropriate changes toAccelerator.load_stateto support the loading of the savedstep.Fixes #2702
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@muellerzr