Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable config for fsdp activation checkpointing #2779

Conversation

helloworld1
Copy link
Contributor

What does this PR do?

The fsdp_activation_checkpointing config does not currently take effect. The fsdp_plugin still get fsdp_activation_checkpointing = False for the following config

fsdp_config:                                                                                                                        
  fsdp_auto_wrap_policy: TRANSFORMER_BASED_WRAP                                                                                     
  fsdp_backward_prefetch: BACKWARD_PRE                                                                                              
  fsdp_cpu_ram_efficient_loading: true                                                                                              
  fsdp_forward_prefetch: false                                                                                                      
  fsdp_offload_params: false                                                                                                        
  fsdp_sharding_strategy: FULL_SHARD                                                                                                
  fsdp_state_dict_type: SHARDED_STATE_DICT                                                                                          
  sync_module_states: true                                                                                                          
  fsdp_use_orig_params: true                                                                                                        
  fsdp_activation_checkpointing: true     

This PR enables configuration of fsdp_activation_checkpointing

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@pacman100
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muellerzr
Copy link
Collaborator

@helloworld1 can you do:

pip install -e .[quality] + make style; make quality?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@helloworld1
Copy link
Contributor Author

helloworld1 commented May 14, 2024

Fixed! Thanks!

@muellerzr muellerzr merged commit befd87f into huggingface:main May 15, 2024
23 checks passed
yhna940 pushed a commit to yhna940/accelerate that referenced this pull request May 16, 2024
* Enable config for fsdp activation checkpointing

* Fix ruff errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants