fix comet ml test #2804
Merged
fix comet ml test #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
muellerzr
reviewed
May 27, 2024
muellerzr
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes the comet ml test that is failing on the CI. The issue is that there is a breaking change in their latest version. The payload structure is not the same anymore:
old version:
'{"payload":{"local_timestamp":1716817708970,"log_other":{"key":"my_text","val":"some_value"},"message_id":20},"type":"ws_msg"}'new version:
'{"payload":{"key":"my_text","message_id":20,"value":"some_value"},"type":"log_other"}'This seems intentional on comet-ml side, so O'm fixing how we parse the results.