Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torch version check #3024

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Fix torch version check #3024

merged 3 commits into from
Aug 19, 2024

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

The current version check doesn't actually do what it's meant to, as 2.1.0a gets parsed as LT for 2.1.0, making it impossible to do FSDP properly for MS-AMP rn.

Technically this is true, but it works so we can adjust this.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan

@muellerzr muellerzr mentioned this pull request Aug 16, 2024
5 tasks
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not quite understand the issue yet. To me, it looks like the two are equivalent:

>>> from accelerate.utils import compare_versions
>>> from packaging.version import Version
>>> compare_versions(Version("2.1.0"), "<", "2.1.0a")
False
>>> not compare_versions(Version("2.1.0"), ">=", "2.1.0a")
False
>>> compare_versions(Version("2.1.0a"), "<", "2.1.0")
True
>>> not compare_versions(Version("2.1.0a"), ">=", "2.1.0")
True

In what situation do you see the discrepancy?

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muellerzr muellerzr merged commit 7ffe766 into main Aug 19, 2024
28 checks passed
@muellerzr muellerzr deleted the fix-fsdp-main-version branch August 19, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants