Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Upgrade ruff to v0.6.4 #3095

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

BenjaminBossan
Copy link
Member

What does this PR do?

Currently used version, 0.2.1, is quite old at this point.

Not a lot needed to be changed:

  • Change ruff version in setup.py
  • Remove deprecated ignore-init-module-imports option for ruff
  • Type comparison should use is not and not !=
  • Use f-string instead of % formatting
  • Some line wrapping and empty lines

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Currently used version, 0.2.1, is quite old at this point.

Not a lot needed to be changed:

- Change ruff version in setup.py
- Remove deprecated ignore-init-module-imports option for ruff
- Type comparison should use is and not ==
- Use f-string instead of % formatting
- Some line wrapping and empty lines
@BenjaminBossan BenjaminBossan changed the title Mnt upgrade ruff 0.6.4 MAINT: Upgrade ruff to v0.6.4 Sep 10, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀 Very happy that it's not a crazy diff difference :)

@muellerzr muellerzr merged commit 3fd02e6 into huggingface:main Sep 10, 2024
24 of 25 checks passed
@BenjaminBossan BenjaminBossan deleted the mnt-upgrade-ruff-0.6.4 branch September 10, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants