Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Permission for GH token in stale.yml #3102

Conversation

BenjaminBossan
Copy link
Member

What does this PR do?

See huggingface/peft#2061 for the equivalent PR in PEFT.

This restores the functionality of the stale bot after permissions for the token have been limited. The action still shows errors for PEFT but the bot appears to work fine.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

See huggingface/peft#2061 in PEFT.

This restores the functionality of the stale bot after permissions for
the token have been limited. The action still shows errors for PEFT but
the bot appears to work fine.
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for investigating it!

@muellerzr muellerzr merged commit 3a670bd into huggingface:main Sep 11, 2024
25 checks passed
@BenjaminBossan BenjaminBossan deleted the mnt-permission-github-token-stale-bot branch September 12, 2024 08:54
BenjaminBossan added a commit to BenjaminBossan/accelerate that referenced this pull request Sep 13, 2024
Continuation of huggingface#3102.

The equivalent PR in
PEFT (huggingface/peft#2064) was successful to
restore stale bot function to PRs as well. Hence also making the same
change for accelerate.
muellerzr pushed a commit that referenced this pull request Oct 7, 2024
Continuation of #3102.

The equivalent PR in
PEFT (huggingface/peft#2064) was successful to
restore stale bot function to PRs as well. Hence also making the same
change for accelerate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants