Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup test_sync w/ deprecated stuff #3109

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fixup test_sync w/ deprecated stuff #3109

merged 1 commit into from
Sep 13, 2024

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Should be the last fix needed (but isn't really needed for the pre-release), last sneaky parts of the deprecation

Fixes main

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !

@muellerzr muellerzr merged commit 521eb5b into main Sep 13, 2024
28 checks passed
@muellerzr muellerzr deleted the fix-sync branch September 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants