Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup multiple model DS tests #3131

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fixup multiple model DS tests #3131

merged 2 commits into from
Sep 26, 2024

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Fixes failures on DS tests wrt multiple models.

TL;DR:

  1. Need to remember to call AcceleratorState.reset_state() when we want to do things in concurrent different configurations (such as the multiple ds model configuration tests that actually do things)
  2. Still need patch_environment to properly setup everything, otherwise we end up with failures when running the entire DS suite at once.

Fixes our tests & deepspeeds PR's from failing

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing ! Make sense !

@muellerzr muellerzr merged commit 018a99e into main Sep 26, 2024
28 checks passed
@muellerzr muellerzr deleted the muellerzr-fix-ds-tests branch September 26, 2024 16:57
loadams added a commit to microsoft/DeepSpeed that referenced this pull request Sep 27, 2024
…6583)

HF accelerate implemented fixes here:
huggingface/accelerate#3131

This means we can revert the changes from #6574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants