Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLU devices : Checks if mlu is available via an cndev-based check which won't trigger the drivers and leave mlu #3187

Merged
merged 42 commits into from
Oct 24, 2024

Conversation

huismiling
Copy link
Contributor

What does this PR do?

MLU devices : Checks if mlu is available via an cndev-based check which won't trigger the drivers and leave mlu

Check devices(cuda and mlu) is available with patch_environment .

Move clear_environment and patch_environment into src/accelerate/utils/environment.py to avoid circular import .

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@huismiling
Copy link
Contributor Author

@BenjaminBossan @muellerzr
Previous PR #3057 is closed.
Sorry for taking so long time to fix circular import.
clear_environment and patch_environment are moved into src/accelerate/utils/environment.py .

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes sense that we do the realignment here of things & how they ended up.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for coming back to this PR, LGTM.

Short question for @muellerzr: We should be fine with the functions no longer being importable from accelerate.utils.other because users should always import from the higher level, right?

@muellerzr
Copy link
Collaborator

Yep exactly. We can add a deprecation warning here but we've never advertised it in that way at that import level so I think we should be fine.

@BenjaminBossan
Copy link
Member

Okay, great, just wanted to be sure. This PR is good to be merged from my point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants