-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLU devices : Checks if mlu is available via an cndev-based check which won't trigger the drivers and leave mlu #3187
Conversation
it's beautiful ! Co-authored-by: Zach Mueller <muellerzr@gmail.com>
…sed` check which won't trigger the drivers and leave mlu uninitialized.
…ch won't trigger the drivers and leave mlu
@BenjaminBossan @muellerzr |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Makes sense that we do the realignment here of things & how they ended up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for coming back to this PR, LGTM.
Short question for @muellerzr: We should be fine with the functions no longer being importable from accelerate.utils.other
because users should always import from the higher level, right?
Yep exactly. We can add a deprecation warning here but we've never advertised it in that way at that import level so I think we should be fine. |
Okay, great, just wanted to be sure. This PR is good to be merged from my point of view. |
What does this PR do?
MLU devices : Checks if mlu is available via an cndev-based check which won't trigger the drivers and leave mlu
Check devices(cuda and mlu) is available with
patch_environment
.Move
clear_environment
andpatch_environment
intosrc/accelerate/utils/environment.py
to avoid circular import .Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.