Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post on bitsandbytes integration on Hugging Face #463

Merged
merged 60 commits into from
Aug 17, 2022

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Aug 11, 2022

A blog post explaining the method 8-bit Matrix Multiplication for transformers at scale and how this is used under the hood in transformers !

  • Still a WIP PR

TODOs

  • change the main thumbnail
  • add more content
  • correct content
  • re-capture the gif out-quant.gif because we can see the mouse

_blog.yml Outdated Show resolved Hide resolved
@stas00
Copy link
Contributor

stas00 commented Aug 12, 2022

You might want to share in the OP the preview link that will remain fixed through this PR's mods.
https://github.com/younesbelkada/blog/blob/add_bnb_inference/hf-bitsandbytes-integration.md
it's much easier to read that way.

the broken images in the html header part is normal - will appear normally once published.

@younesbelkada
Copy link
Contributor Author

Great thanks for the tip! I have changed the previous names of some pictures and now all images should be rendered correctly

Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first part review

I will stop here for now, the text needs heavy editing - if you'd trust my approach - after we discuss the above suggestions - perhaps it'd be easier if I edited the text directly? as it's quite painful to edit each sentence in github. You will still see a diff and we can tweak further.

@younesbelkada
Copy link
Contributor Author

Thank you very much for your review! This will be extremely helpful
Yes we can go for this approach, I can give you access to the google doc I used to write the text if you prefer

Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
@stas00
Copy link
Contributor

stas00 commented Aug 12, 2022

no google doc needed, we are already editing here, it'd be extremely difficult to keep 2 separate docs in sync. So let's switch to editing here 100%.

As I shared earlier the preview link should serve as a nice visual that's easier to read than raw MD.

younesbelkada and others added 2 commits August 12, 2022 23:43
- add more details and adapt from stas suggestions
@stas00
Copy link
Contributor

stas00 commented Aug 13, 2022

I've pushed the rewrite of the first few sections. Please let me know if it feels good and then I will continue reworking the rest when you're asleep next time, so that we don't collide on our edits.

I wonder if perhaps you'd want to first finish the rough version first and I will do the heavy editing afterwards? It's your call.

@younesbelkada
Copy link
Contributor Author

Just finished my round of editing @stas00 ! Please let me know if the proposed modifications make sense to you 🙏
Regarding #463 (comment) I will probably let Tim answer on that one! Again thank you for your feedback so far 🔥

Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
_blog.yml Outdated Show resolved Hide resolved
@younesbelkada
Copy link
Contributor Author

Looks good to me now!
cc @stevhliu I think that we are ready to merge now 💪

@stevhliu stevhliu merged commit d339f36 into huggingface:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants