-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post on bitsandbytes
integration on Hugging Face
#463
Conversation
You might want to share in the OP the preview link that will remain fixed through this PR's mods. the broken images in the html header part is normal - will appear normally once published. |
Great thanks for the tip! I have changed the previous names of some pictures and now all images should be rendered correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first part review
I will stop here for now, the text needs heavy editing - if you'd trust my approach - after we discuss the above suggestions - perhaps it'd be easier if I edited the text directly? as it's quite painful to edit each sentence in github. You will still see a diff and we can tweak further.
Thank you very much for your review! This will be extremely helpful |
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
no google doc needed, we are already editing here, it'd be extremely difficult to keep 2 separate docs in sync. So let's switch to editing here 100%. As I shared earlier the preview link should serve as a nice visual that's easier to read than raw MD. |
- add more details and adapt from stas suggestions
I've pushed the rewrite of the first few sections. Please let me know if it feels good and then I will continue reworking the rest when you're asleep next time, so that we don't collide on our edits. I wonder if perhaps you'd want to first finish the rough version first and I will do the heavy editing afterwards? It's your call. |
Just finished my round of editing @stas00 ! Please let me know if the proposed modifications make sense to you 🙏 |
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Looks good to me now! |
A blog post explaining the method
8-bit Matrix Multiplication for transformers at scale
and how this is used under the hood intransformers
!TODOs
out-quant.gif
because we can see the mouse