-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onnx: ReduceMin/Max Ops #2563
Merged
LaurentMazare
merged 13 commits into
huggingface:main
from
AnubhabB:onnx-reduce-min-max
Oct 15, 2024
Merged
onnx: ReduceMin/Max Ops #2563
LaurentMazare
merged 13 commits into
huggingface:main
from
AnubhabB:onnx-reduce-min-max
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d would be documented in the readme
Falling back to taking the axis from the input if they are not present in the attributes sounds pretty reasonable to me.
I guess we can just error out in this case for the moment, and if anyone runs into this issue then we can have a look at what the failing onnx model actually expects. |
Thanks @LaurentMazare. I've amended the PR with the following:
Guess this is good to go! |
LaurentMazare
approved these changes
Oct 15, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ReduceMin and ReduceMax Ops. Found these in use in a Detectron2 exported model.
Implementation
Supports Ops version 18+Backward compatible as far as I can tellOpen Questions
13 -> 18
has moved theaxes
fromattributes
toinput
. Though it's trivial to handle this withget_attr_opt::<&[i64]>(node, "axes")
fallback, not sure if that's the right way of going about this!empty set
as input and prescribes-INF/ +INF
orDatatype::Min/ Datatype::Max
for the ops. Reference. I'm not sure if the return is supposed to be ascalar
?@LaurentMazare, any thoughts around these open questions?