Book 3 (advanced loading + hub) #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
commented
Jul 28, 2023
Narsil
force-pushed
the
book_3
branch
2 times, most recently
from
c3e8403 to
def0e5a
Compare
Narsil
changed the title
Narsil
changed the title
- Loading with memmap - Loading a sharded tensor - Moved some snippets to `candle-examples/src/lib.rs` This is because managing book specific dependencies is a pain rust-lang/mdBook#706 - This causes a non aligned inclusion rust-lang/mdBook#1856 which we have to ignore fmt to remove. mdbook might need some more love :)
| @@ -1 +1,3 @@ | |||
| # Serialization | |||
|
|
|||
| Once you have a r | |||
There was a problem hiding this comment.
Missing some content here?
There was a problem hiding this comment.
Possibly. :)
I'll remove that file
|
Modified so now the push to the book happens only when we merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purposefully ignoring
VarBuilder. It's not a good abstraction yet, and is not necessaryin a tutorial IMO. Linking to the actual example currently leads to VarBuilder
but will automatically be fixed. once we fix it.
The current BACKTRACE is also not very readable in external code atm (but it does contain the actual useful information).
candle-examples/src/lib.rsThis is becausemanaging book specific dependencies is a pain Add ability to reference 3rd-party crates rust-lang/mdBook#706
to ignore fmt to remove.